On Thu, May 18, 2023 at 03:14:50PM -0400, Todd Zullinger wrote: > > 1. You use the looser value of GIT_TEST_HTTPD for CentOS tests, which > > would do the right thing. The downside is that if server setup > > failed for other reasons, we wouldn't notice and would silently > > skip the HTTP tests. > > > > 2. We do some kind of version check in enable_cgipassauth(), > > and skip tests manually if it doesn't pass. > > > > 3. You just skip the test manually on that platform with > > GIT_SKIP_TESTS=t5563. > > > > Obviously (1) and (3) are the least work for us upstream, but I don't > > think (2) would be too hard to do. > > Yeah, the path of least effort seems ideal here. If the > tests are split I can easily skip them for CentOS 7. For > something that's going away in little over a year, it's good > to put at least some of the onus on folks packaging for it. > And that's less cruft in the test suite after CentOS 7 is > gone (or any other ancient httpd's git may wish to support). Too late. :) I just sent a patch with (2), as it was only a few extra lines. > Thanks Peff! I'm really glad you know your way around the > test suite so well. It'd take me far longer to figure out a > good plan for something like this. I was able to cheat a little, having had to figure out a similar solution for HTTP/2 not too long ago. :) -Peff
