On Fri, May 12, 2023 at 2:28 PM Jonathan Tan <jonathantanmy@xxxxxxxxxx> wrote: > > "Elijah Newren via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: > > From: Elijah Newren <newren@xxxxxxxxx> > > > > Much like the former commit, this commit was prompted by a desire to > > Could we have s/former/parent? I'm not used to "former" with this > meaning (but if it's understood by others, then that's fine). Sure, I'll make the switch. > > diff --git a/builtin/clone.c b/builtin/clone.c > > index 15f9912b4ca..cc34c194f5e 100644 > > --- a/builtin/clone.c > > +++ b/builtin/clone.c > > @@ -930,6 +930,7 @@ int cmd_clone(int argc, const char **argv, const char *prefix) > > int submodule_progress; > > int filter_submodules = 0; > > int hash_algo; > > + const int do_not_override_repo_unix_permissions = -1; > > I don't really like this name, but init_db() is undocumented so an > anonymous -1 at the call site is not much better. For the purposes of > this patch set (getting rid of cache.h), this should be fine for now.