During recent review of a topic, I noticed that there are a handful
of places where we misuse test_path_is_{file,directory} test helper
functions. They are designed to be silent when the given path is
of the expected type, so
! test_path_is_file foo
when you do not want 'foo' to be a file, while making the test pass,
does not help debugging when things go wrong.
These small patches touch the places where
$ git grep -e '! test_path_' t/
shows hits, except for test_path_is_hidden that shares the same name
pattern but is not designed to help debugging like others.
Junio C Hamano (3):
tests: do not negate test_path_exists
t2021: do not negate test_path_is_dir
test: do not negate test_path_is_* to assert absense
t/lib-submodule-update.sh | 2 +-
t/t2021-checkout-overwrite.sh | 2 +-
t/t4067-diff-partial-clone.sh | 4 ++--
t/t4115-apply-symlink.sh | 2 +-
t/t5572-pull-submodule.sh | 4 ++--
5 files changed, 7 insertions(+), 7 deletions(-)
--
2.41.0-rc0
