"Elijah Newren via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: > From: Elijah Newren <newren@xxxxxxxxx> > > Since this header showed up in some places besides just #include > statements, update/clean-up/remove those other places as well. > > Note that compat/fsmonitor/fsm-path-utils-darwin.c previously got > away with violating the rule that all files must start with an include > of git-compat-util.h (or a short-list of alternate headers that happen > to include it first). This change exposed the violation and caused it > to stop building correctly; fix it by having it include > git-compat-util.h first, as per policy. > > Signed-off-by: Elijah Newren <newren@xxxxxxxxx> Ah, a monumental effort indeed (to finally remove cache.h). This patch was one of a few called out in the cover letter [1] as needing reviewer focus, but this patch seemed straightforward to me (changing the text wherever cache.h is mentioned in relatively obvious ways) so hopefully I'm not missing anything.