On Mon, May 15, 2023, at 09:00, Junio C Hamano wrote: > Does this document the current behaviour, i.e. before applying the > patch [3/3]? Or is this a new test designed to fail until [3/3] is > applied? > > If the latter, please don't [*]. Yep, I was going for the latter. I’ll combine [2/3] and [3/3]. > Imitate other tests that expect a controlled failure from our > command, and write something like > > test_must_fail env GIT_EDITOR=./fakeeditor git tag -a foo > > so that a segfaulting "git tag" will not count as "failing as > expected". Ah, I was wondering how to use `test_must_fail` on a command with an environment variable. Thanks. -- Kristoffer Haugsbakk
