"Corentin Garcia via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: > From: Corentin Garcia <corenting@xxxxxxxxx> > > Add the unit (bytes per second) for http.lowSpeedLimit > in the documentation. > > Signed-off-by: Corentin Garcia <corenting@xxxxxxxxx> > --- SOunds good. > doc/git-config: add unit for http.lowSpeedLimit > > Add the unit (bytes per second) for http.lowSpeedLimit in the > documentation. You do not have to repeat your log message here. > diff --git a/Documentation/config/http.txt b/Documentation/config/http.txt > index afeeccfbfa7..51a70781e58 100644 > --- a/Documentation/config/http.txt > +++ b/Documentation/config/http.txt > @@ -246,8 +246,9 @@ significantly since the entire buffer is allocated even for small > pushes. > > http.lowSpeedLimit, http.lowSpeedTime:: > - If the HTTP transfer speed is less than 'http.lowSpeedLimit' > - for longer than 'http.lowSpeedTime' seconds, the transfer is aborted. > + If the HTTP transfer speed, in bytes per second, is less than > + 'http.lowSpeedLimit' for longer than 'http.lowSpeedTime' seconds, > + the transfer is aborted. > Can be overridden by the `GIT_HTTP_LOW_SPEED_LIMIT` and > `GIT_HTTP_LOW_SPEED_TIME` environment variables. As the variable is read with git_config_int(), this also allows the usual k/m/g suffix to scale, i.e. specifying it to 500k would mean 500*1024 bytes. I wonder if that is also worth documenting, or it is too obvious. Let's queue this patch as-is. If somebody wants to elaborate on how the numbers can be spelled, that can be done in a separate patch. Thanks.
