On 11/05/2023 22:42, Junio C Hamano wrote:
Calvin Wan <calvinwan@xxxxxxxxxx> writes: So this step, while it makes sense in a vacuum, is a cute idea, and is nicer in the longer term (because we certainly do not want to have to pass an extra parameter to the function), raises the risk of semantic mismerge higher for topics in flight that do want to use stripspace to remove lines that are commented out. My quick "git log -S" seems to tell me there is no such topic I happened to have picked up in 'seen' right now, though, so it may be OK.
I just grepped seen for strbuf_stripspace() and it looks like all the callers are converted correctly.
Best Wishes Phillip
