On Thu, May 11, 2023 at 06:09:03PM -0700, Glen Choo wrote: > Patrick Steinhardt <ps@xxxxxx> writes: > > > Changes compared to v4: > > > > - Patch 1/9: Simplified the test as proposed by Junio and Glen. > > > > - Patch 3/9: Added a test to verify that `git fetch -c fetch.output` > > without a value set fails as expected. Also dropped the tests that > > checked whether stdout was empty. > > > > - Patch 4/9: Reformulated the commit message to treat the missing > > left-hand side of displayed references as an inconsistency instead > > of a bug. I've also added a testcase to verify that direct OID > > fetches continue to work as expected. > > > > - Patch 5/9: New patch that makes calculation of the table width for > > displayed reference updates self-contained in `refcol_width()`. > > This is a preparatory refactoring that should make patch 6/9 > > easier to review. > > > > - Patch 7/9: Refactored the code to parse the "fetch.output" config > > variable inside of `git_fetch_config()` before we parse command > > line options. Also fixed that the commit message was still > > referring to `--output-format=porcelain` instead of the new > > `--porcelain` switch. > > > > - Patch 9/9: The `--porcelain` option is now a simple `OPT_BOOL()` > > that can be negated. Added a test that `--no-porcelain` works as > > expected. > > I didn't spot any blocking issues in this version, and the various > improvements (especially 6-7/9) are really welcome. I also read through > Junio's comments, but I didn't spot anything that I thought should block > the series, so I'm happy to leave > > Reviewed-by: Glen Choo <chooglen@xxxxxxxxxx> Thanks a lot for your reviews! Patrick
Attachment:
signature.asc
Description: PGP signature
