Re: [PATCH v5 9/9] fetch: introduce machine-parseable "porcelain" output format

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Patrick Steinhardt <ps@xxxxxx> writes:

> +test_expect_success 'fetch --no-porcelain overrides previous --porcelain' '
> +	test_when_finished "rm -rf no-porcelain" &&
> +
> +	git switch --create no-porcelain &&
> +	git clone . no-porcelain &&
> +	test_commit --no-tag no-porcelain &&
> +	old_commit=$(git rev-parse --short HEAD~) &&
> +	new_commit=$(git rev-parse --short HEAD) &&
> +
> +	cat >expect <<-EOF &&
> +	From $(test-tool path-utils real_path .)/.
> +	   $old_commit..$new_commit  no-porcelain -> origin/no-porcelain
> +	EOF
> +
> +	git -C no-porcelain fetch --porcelain --no-porcelain >stdout 2>stderr &&
> +	test_cmp expect stderr &&
> +	test_must_be_empty stdout
> +'

(This shouldn't block the series) As a matter of taste, it feels like
overkill to construct the whole output to check if --no-porcelain wins.
Maybe in a future cleanup, we would go through the tests in this file
and see where it is really important that we have the exact output and
where it is not.



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux