On Thu, May 11, 2023 at 12:28:45PM -0400, Eric Sunshine wrote: > > So the code is working as intended, but I may have misused the term > > "main" with respect to other worktree code. I didn't even know that was > > a concept, not having dealt much with worktrees. > > > > Maybe it's worth s/main/current/ here (and I guess in t1450)? > > Yes, s/main/current/ probably would be helpful for future readers of > the code. It's unfortunate that the term "current" can ambiguously > also be read as meaning "the up-to-date index" or "the present-time > index" as opposed to "the index in this directory/worktree", which is > the intention here. But "current" is consistent with the existing > `struct worktree.is_current`, so hopefully should not be too > confusing. I think in this context it should be pretty clear. Do you want to prepare a patch? -Peff
