I intend to reroll it, as well as rewording the commit patches 4 and 5 as per Elijah's suggestions. I didn't originally realize you were referring to s/environment variable/global variable as the misnomer (since the dependency I was removing was from environment.h) On Fri, May 5, 2023 at 3:33 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > Calvin Wan <calvinwan@xxxxxxxxxx> writes: > > > Strbuf is a widely used basic structure that should only interact with > > other primitives in strbuf.[ch]. Over time certain functions inside of > > strbuf.[ch] have been added to interact with higher level objects and > > functions. This series cleans up some of those higher level interactions > > by moving the offending functions to the files they interact with and > > adding documentation to strbuf.h. With the goal of eventually being able > > to stand up strbuf as a libary, this series also removes the use of > > environment variables from strbuf. > > This round hasn't seen any comments (mine does not count ;-). The > 7/7-only v3 still says "environment variable" to refer to a global > variable, so I am not sure where we stand. Is this back-burnered? >
