On Wed, May 3, 2023 at 11:00 AM Calvin Wan <calvinwan@xxxxxxxxxx> wrote: > > While moving strbuf_add_separated_string_list() to a separate file > would mean that strbuf would no longer have a dependency on > string-list, I don't think that dependency is problematic to begin > with. Widening the boundary for strbuf as a string manipulation > library to a string and string list manipulation library seems > reasonable to me. Oh, the high level idea behind string-list might make sense at this level, but I was assuming Peff would show up at some point and highlight the evils of the current string-list API[1][2][3] and how we should avoid using, depending on, or implementing something that acts like it. :-) Of course, you're explicitly not trying to make any API or ABI guarantees, so it's certainly fine to shelve or defer such cleanups for later. [1] https://lore.kernel.org/git/Y7lx1hUpZ7zOP1Lo@xxxxxxxxxxxxxxxxxxxxxxx/ [2] https://lore.kernel.org/git/20180906191203.GA26184@xxxxxxxxxxxxxxxxxxxxx/ [3] https://lore.kernel.org/git/20200821200121.GF1165@xxxxxxxxxxxxxxxxxxxxxxx/
