Re: [PATCH v2] usage: clarify --recurse-submodules as a boolean

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Junio C Hamano <gitster@xxxxxxxxx> writes:

> Emily Shaffer <nasamuffin@xxxxxxxxxx> writes:
>
>> `git switch` `git checkout`, `git reset`, and `git read-tree` allow a
>
> Missing comma?
>
>> user to choose to recurse into submodules. All four of these commands'
>> short usage seems to indicate that `--recurse-submodules` should take an
>> argument. In practice, though, all four of these commands parse through
>> the same callback path:
>>
>>   option_parse_recurse_submodules_worktree_updater(...) checks for
>>   set/unset, or passes off to...
>>   parse_update_recurse_submodules_arg(...), which is a straight handoff
>>   to...
>>   parse_update_recurse(...), which only accepts true or false.
>
> "true or false" -> "various forms of 'true' (e.g. on/1/yes) or 'false'"
>
>> So ultimately, it can only be true or false, unlike `git push
>
> Likewise.  Here is a minimally touched up version I queued.
>
> Thanks.
> ...

Any updates on this topic?



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux