Re: [PATCH] docs: clarify git rm --cached function in gitignore note

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Tue, May 2, 2023 at 5:33 PM Sohom <sohomdatta1@xxxxxxxxx> wrote:
>
> Hey maintainers,
>
> Friendly ping regarding this patch (I assume it slipped through the cracks).
>
> It would be great if the change could be made to the git documentation, since
> it still is a common misconception amongst students that merely adding a file
> to .gitignore will lead to the file being automagically ignored by git when that
> is in fact not the case.
>
> P.S: sohomdatta1+git@xxxxxxxxx and sohom.datta@xxxxxxxxxxxxxxxxxxx are both me,
> that email was used by me previously when I was affiliated to my university.
>
> Regards,
> Sohom Datta.

Yeah, looks like it slipped through the cracks.  The documentation
change looks reasonable to me, though given the time that has passed,
the context region has changed so it no longer cleanly applies.  Could
you rebase it and resubmit?

Also, while rebasing, the "isn't analogous" part of the commit message
feels like it misses the mark in the explanation, and the body of the
commit message would be better worded in the imperative tense.
Perhaps change the main paragraph to something like:

Explain to users that the step to untrack a file will not also keep it
untracked in the future.

When you resubmit, go ahead and cc me.




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux