Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: >> +#define S_DIFFTREE_IFXMIN_NEQ 0x80000000 >> + >> /* >> * internal mode marker, saying a tree entry != entry of tp[imin] >> * (see ll_diff_tree_paths for what it means there) > > As it's only used in tree-diff.c, should this change not be instead > changing how we define S_IFXMIN_NEQ itself, and combining the two > comments seen here (the latter only partially, in the context). Yup, the end result should look cleaner with this extra bit of tweak. Thanks for carefully reading the patch.
