Re: [PATCH] revisions.txt: correct a mistake in dotted range notations section

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 26, 2023 at 1:00 AM Pooyan Khanjankhani via GitGitGadget
<gitgitgadget@xxxxxxxxx> wrote:
> From: Pooyan Khanjankhani <p.khanjankhani@xxxxxxxxxxxx>
>
> Insert a missing 'not' word in a negative sentence.
>   ... but are [not] reachable from neither A or C.

There's a peculiarity of the English language here that means you
should not use the word "not". The actual error is using "or" as
the conjunction, instead of "nor": the construct should read
"neither <alternative 1> nor <alternative 2>", and it means that
both alternatives are rejected.

That said, there's almost certainly a reformulation that uses
language less-confusing to non-native speakers.  Perhaps
this is better (I haven't actually made a commit of this, it's just
a diff in place):

diff --git a/Documentation/revisions.txt b/Documentation/revisions.txt
index 9aa58052bc..5460820377 100644
--- a/Documentation/revisions.txt
+++ b/Documentation/revisions.txt
@@ -305,14 +305,14 @@ other, e.g.
     $ git log A..B C..D

 does *not* specify two revision ranges for most commands.  Instead
-it will name a single connected set of commits, i.e. those that are
-reachable from either B or D but are reachable from neither A or C.
-In a linear history like this:
+it will name a single connected set of commits: those that are
+reachable from either B or D, but not reachable from either A or C.
+For example, in a linear history like this:

     ---A---B---o---o---C---D

 because A and B are reachable from C, the revision range specified
-by these two dotted ranges is a single commit D.
+by these two dotted ranges is the single commit D.


 Other <rev>{caret} Parent Shorthand Notations


Chris




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux