On Tue, Apr 25, 2023 at 9:47 PM Carlo Marcelo Arenas Belón <carenas@xxxxxxxxx> wrote: > Since 846a29afb0 (config.mak.dev: workaround gcc 12 bug affecting > "pedantic" CI job, 2022-04-15), DEVELOPER mode has this workaround > for the version of gcc that was released with Fedora 36. > > That version of Fedora is about to be EOL and latest versions of > the compiler don't have that bug anymore, so remove the workaround. > > Tested not to trigger with latest gcc packages from the last 3 > Fedora releases, including gcc 13 from Fedora 38. The commit message doesn't explain the benefit of removing this workaround. Is it because it's a maintenance burden? Or is it preventing some future planned improvement in this area? What is the justification for penalizing users who might be stuck on Fedora 36 for some reason or another? (I ask these questions as a person who regularly is stuck on old platforms for which it is increasingly painful or impossible to build or install modern software.) > Signed-off-by: Carlo Marcelo Arenas Belón <carenas@xxxxxxxxx> > --- > diff --git a/config.mak.dev b/config.mak.dev > index 981304727c..6d07ef3692 100644 > --- a/config.mak.dev > +++ b/config.mak.dev > @@ -94,9 +94,4 @@ endif > endif > endif > > -# https://bugzilla.redhat.com/show_bug.cgi?id=2075786 > -ifneq ($(filter gcc12,$(COMPILER_FEATURES)),) > -DEVELOPER_CFLAGS += -Wno-error=stringop-overread > -endif > - > GIT_TEST_PERL_FATAL_WARNINGS = YesPlease
