On Tue, Apr 25, 2023 at 11:32:25AM -0700, Junio C Hamano wrote: > Taylor Blau <me@xxxxxxxxxxxx> writes: > > > To prepare for the boundary-based bitmap walk to perform a fill-in > > traversal using the boundary of either side as the tips, extract routine > > used to perform fill-in traversal by `find_objects()` so that it can be > > used in both places. > > What is done is not a literal "extract", though. Worth mentioning here? Oops. It is supposed to be a literal extraction, but this patch was originally written before 3e0370a8d2 (list-objects: consolidate traverse_commit_list[_filtered], 2022-03-09). > > --- > > pack-bitmap.c | 66 +++++++++++++++++++++++++++++---------------------- > > 1 file changed, 37 insertions(+), 29 deletions(-) > > > > + if (base == NULL) > > + base = bitmap_new(); > > Style? ...It was also written before afe8a9070b (tree-wide: apply equals-null.cocci, 2022-05-02), which is where this "if (base == NULL)" thing comes from. I fixed both to be a clean extraction with no functional changes. Thanks, Taylor
