I eyeballed the whole thing (not the same as real tests of course) and it looks good, but there's one typo (missing-word-o) here of note: On Mon, Apr 24, 2023 at 3:20 PM Taylor Blau <me@xxxxxxxxxxxx> wrote: ... > But there are no instances of this in Git's tree which are more > well-suited to `strtok_r()` than the friendlier > `string_list_in_place()`, so ban `strtok_r()`, too. > > Signed-off-by: Taylor Blau <me@xxxxxxxxxxxx> Missing `split_`. Probably not worth a re-roll... Chris