How can `git describe --match 'foo*'` return something that doesn't contain 'foo' and without error? It can't, so no need for check for the impossible. Signed-off-by: Felipe Contreras <felipe.contreras@xxxxxxxxx> --- GIT-VERSION-GEN | 17 +++-------------- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/GIT-VERSION-GEN b/GIT-VERSION-GEN index 34f561752b..e99c7b45c0 100755 --- a/GIT-VERSION-GEN +++ b/GIT-VERSION-GEN @@ -3,22 +3,11 @@ GVF=GIT-VERSION-FILE DEF_VER=v2.40.GIT -LF=' -' - describe () { VN=$(git describe --match "v[0-9]*" 2>/dev/null) || return 1 - case "$VN" in - *$LF*) - return 1 - ;; - v[0-9]*) - git update-index -q --refresh - test -z "$(git diff-index --name-only HEAD --)" || - VN="$VN-dirty" - return 0 - ;; - esac + git update-index -q --refresh + test -z "$(git diff-index --name-only HEAD --)" || + VN="$VN-dirty" } # First see if there is a version file (included in release tarballs), -- 2.40.0+fc1