On Tue, Apr 18, 2023 at 03:50:33PM -0400, Taylor Blau wrote: > > > @@ -151,7 +151,7 @@ test_expect_success 'do not complain about existing broken links (commit)' ' > > > some message > > > EOF > > > commit=$(git hash-object -t commit -w broken-commit) && > > > - git gc -q 2>stderr && > > > + git gc --no-cruft -q 2>stderr && > > > verbose git cat-file -e $commit && > > > test_must_be_empty stderr > > > ' > > > > The idea is that we don't complain when repacking unreachable-but-broken > > segments of history. Which could perhaps behave differently for objects > > that are going into a cruft pack versus being turned loose. So maybe > > it's worth covering for the --cruft case, too. I dunno. > > I think we already have coverage of those cases in t5329, specifically > in the tests: > > - cruft packs tolerate missing trees (expire $expire) > - cruft packs tolerate missing blobs (expire $expire) > > which are tested for both the pruning and non-pruning implementations > (by setting $expire to "2.weeks.ago", and "never", respectively). Ah, perfect. I only gave a quick look over t5329, and didn't see those. So yeah, I think it is fine to just have this whole script run in no-cruft mode. -Peff
