On Thu, Apr 20, 2023 at 03:34:26PM -0700, Junio C Hamano wrote: > * tb/ban-strtok (2023-04-18) 6 commits > - banned.h: mark `strtok()` as banned > - t/helper/test-json-writer.c: avoid using `strtok()` > - t/helper/test-oidmap.c: avoid using `strtok()` > - t/helper/test-hashmap.c: avoid using `strtok()` > - string-list: introduce `string_list_setlen()` > - string-list: introduce `string_list_split_in_place_multi()` > > Mark strtok() and strtok_r() to be banned. The latest round bans only strtok(), so this description would need updating (probably to something as simple as "Mark strtok() as banned"). > Comments? I would be curious to get Peff's (cc'd) thoughts on this series, since it was something that he and I were talking about off-list. It was one of those "let me see how hard this would be..." topics, that by the time I finished investigating, I had the series ready to go. Thanks, Taylor