On 23/04/17 02:30PM, Junio C Hamano wrote: > Jacob Abel <jacobabel@xxxxxxxxxx> writes: > > [...] > > > [....] > > Again, I do not think this sends output to the standard output at > the end of this test piece. > > > + test_must_fail git worktree add $opts 2>actual && > > + grep -E "fatal:( options)? .* cannot be used together" actual > > + ' > > +} > > I do not think this patch is needed (I'd rather see people learn the > trick of running with "-i" and rely on the fact that the trash > directory is left intact to be inspected), but if you must, it may > make more sense to add test_must_contain to make a failed 'grep > "$@"' easier to see, similar to the way that test_must_be_empty > helps a failing 'test ! -s "$1"', something along the lines of ... > > [...] > > Thanks. Understood. As mentioned in the discussion for patch 2/8, these changes (trying to `cat actual` on `test_cleanup`) will be reverted for the next revision across all patches.
