On Mon, Apr 17, 2023 at 04:54:33PM -0400, Taylor Blau wrote: > In the last commit, we refactored some of the tests in t6500 to make > clearer when cruft packs will and won't be generated by `git gc`. > > Add the remaining cases not covered by the previous patch into this one, > which enumerates all possible combinations of arguments that will > produce (or not produce) a cruft pack. > > This prepares us for the following commit, which will change the default > of `gc.cruftPacks` by ensuring that we understand which invocations do > and do not change as a result. I think "the following commit" is really patch 9. Patch 8 adjusts t6501 (and likewise says "like the previous commits"). It would probably make more sense to put patch 8 before patches 6 and 7. Probably not worth a re-roll on its own, but if you're doing one anyway, it should be easy to do. -Peff
