On 4/15/2023 11:03 PM, Elijah Newren via GitGitGadget wrote: > This series continues to focus on splitting declarations from cache.h to > separate headers. This series also untangles some dependencies between > hash.h and repository.h, and between read-cache.c and tree.[ch], and cleans > up a few other headers. At the end of this series the number of cache.h > includes drops from 189 down to 149. Thank you for continuing to do this work. > * Patch 14-16: move functions between hash<->repository and > read-cache<->tree to simplify dependencies My only comment was on patch 14, where I'm not sure I like the methods moving from hash.h to repository.h. If we can find an alternative, that would make me happy. The rest of the series looked very good. Thanks, -Stolee
