Elijah Newren venit, vidit, dixit 2023-04-16 07:51:03: > On Sat, Apr 15, 2023 at 10:47 PM Elijah Newren <newren@xxxxxxxxx> wrote: > > > > On Sat, Apr 15, 2023 at 4:06 AM Michael J Gruber <git@xxxxxxxxx> wrote: > > > > <snip> > > > A real fix will identify a proper common header file (I couldn't) or > > > create a new one. > > > > I've got a patch that does precisely this that I just submitted as > > part of my follow-on to the en/header-split-cache-h series. I've included > > that patch below in case Junio wants to advance it faster than the rest of > > that series. > > Link to other follow-up series I took this patch from: > https://lore.kernel.org/git/003548de707f57cb9908b6dfbdf42954f668ee43.1681614206.git.gitgitgadget@xxxxxxxxx/ Thanks, protocol.h looks like a good place. I wasn't sure whether daemon.c wants to include it, but I'm fine with it. The change which broke git protocol hit me basically at the same time at which I upgraded my system (F37->F38) which made the first analysis interesting ... Anyway, it's "released" on next only, and the fix is simple, thus not urgent. git.git/next works nicely on Fedora 38 by the way, no surprises with tool chain upgrades so far. Apparantly, we don't test this protocol, and almost all our next users don't use it either ;) Cheers Michael
