On 2023-04-11 at 20:25:13, Taylor Blau wrote: > Hi Jonas, > > On Tue, Apr 11, 2023 at 10:53:59PM +0300, Jonas Haag wrote: > > Hello! > > > > There is an infinite loop with an accompanying memory leak in > > annotate_refs_with_symref_info that was introduced in Git 2.28 (I > > think in commit 2c6a403: “connect: add function to parse multiple v1 > > capability values”). > > I'm not familiar with Klaus and don't have it installed, but a couple of > questions: were you able to reproduce this result with any other forges > or tools, and were you able to confirm that 2c6a403 is the culprit via a > bisection? > > In case the answer to the latter question is "yes", I cc'd brian carlson > on this thread, since they are the original author of that patch. I may be the author of the patch, but I honestly don't remember much about that code except that it was a bear to write, and I am honestly not terribly surprised that it came out less than perfect. I do apologize for the buggy code, though. It looks like Peff has come up with a patch downthread, and a test even, which I think will probably fix the problem, so I'll refrain from sending one myself for now. -- brian m. carlson (he/him or they/them) Toronto, Ontario, CA
Attachment:
signature.asc
Description: PGP signature
