On Mon, Apr 10, 2023 at 10:18:50PM +0000, Glen Choo via GitGitGadget wrote: > I tried teaching dir_iterator_begin() to return an exit code to indicate > that we found a symlink, but it ended up looking quite ugly when I > started to consider plain files as well as generic lstat failures. I > think the extra lstat() is fine as a one-off, but if we need another > instance of this, we'd be better off doing the refactor. ;-). Heh, I was wondering what happened since your [1] made it sound like you would investigate making dir_iterator_begin() return an error code. [1]: https://lore.kernel.org/git/kl6lmt3k3ccc.fsf@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/ > Documentation/git-clone.txt | 5 +++++ > builtin/clone.c | 11 ++++++++++- > t/t5604-clone-reference.sh | 2 +- > 3 files changed, 16 insertions(+), 2 deletions(-) But if it turned out ugly, I don't mind; this version looks great to me. Thanks, Taylor
