Jeff King <peff@xxxxxxxx> wrote: > On Fri, Oct 19, 2007 at 03:39:39AM -0400, Shawn O. Pearce wrote: > > > What about this on top of Jeff's patch? > > > > $ git fetch jc > > ... > > ==> git://repo.or.cz/alt-git.git > > * tag junio-gpg-pub ......................... (new) > > * tag v1.5.0 .......................... (tag moved) > > Ugh. I strongly suspect that it would look ugly on anything bigger than > about 80 columns, anyway. You are probably better off just not worrying > about the terminal width, and always using an 80-ish column total. And > then you don't have to worry about the ugly ioctl call. Then you get linewrap on smaller terminals, and bigger ones don't line up the right side. *shrug* > > + show_update("* branch", note, "->", "FETCH_HEAD", NULL); > > Hrm, btw, I can't seem to get this one to show (I was curious how ugly > the FETCH_HEAD would look). Yea, I can't easily see how to get this to generate. > > if (verbose) > > - fprintf(stderr, " - %s == %s\n", > > - note, pretty_ref); > > + show_update("-", note, "==", pretty_ref, "unchanged"); > > return 0; > > Also, I was unable to generate a test case that showed this one. Did > you? git fetch -v jc > > +static void determine_window_size(void) > > +{ > > + struct winsize ws; > > + if (!ioctl(2, TIOCGWINSZ, &ws)) > > + ws_cols = ws.ws_col; > > +} > > + > > Ugh. How portable is this? No clue. It compiles fine here on Mac OS X and on Linux, but those are both reasonably modern UNIX systems. Older systems like Solaris 8 or an ancient OpenBSD might have an issue. I suspect though that this is a reasonably standard thing but its not in POSIX so uh, probably a bad thing to do. -- Shawn. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html