Re: [PATCH RESEND] hooks: add sendemail-validate-series

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Junio C Hamano, Apr 04, 2023 at 22:14:
> Feeding the filenames as the command line arguments would have been
> much simpler X-<,

Just a thought. Instead of adding another hook, wouldn't it be better to
add an option --validate-series (git config sendemail.validateSeries)
that would change the behaviour of the sendemail-validate hook? Calling
it with all patch files as command line arguments only once instead of
once per file.

I know I was concerned with the max size of the command line args but is
there really a chance that we hit that maximum? On my system, it is
2097152 bytes. Even with a 1000 patches series with 1000 bytes
filenames, we wouldn't hit the limit.

This way, we support any crap filename that the user may send and we
don't add a new hook which basically does the same thing than the
existing one.

Thoughts?




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux