Re: [GSOC][PATCH v4] t3701: don't lose "git" exit codes in test scripts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Apr 2, 2023 at 3:18 PM Edwin Fernando
<edwinfernando734@xxxxxxxxx> wrote:
> Exit codes are lost due to piping: "git ... | <command>"
> Fix these issues using the intermediate step of writing output to file.
>
> Signed-off-by: Edwin Fernando <edwinfernando734@xxxxxxxxx>
> ---
> Apply my changes on top of the latest commit in upstream history.
> Test 76 in t3701 fails. This commit breaks the test:
> a9f4a01760 (Merge branch 'jk/add-p-unmerged-fix', 2023-03-19)
> Identified by checking out commits in:
> "git log --oneline -- t/t3701-add-interactive.sh"
> I don't know if it is normal to have broken tests in the main repository.

It's not normal to have broken tests in the repository; they should not exist.

However, it's not clear what breakage you are seeing. In my testing, I
don't see any failures, either in a9f4a01760 or after applying your
patch to "master". Can you provide more information about the failure
you're experiencing?



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux