Re: [PATCH] Change 'Deltifying objects' to 'Delta compressing objects'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 18, 2007 at 10:21:54PM -0400, Shawn O. Pearce wrote:

> My eyes have gotten used to "Deltifying" but I have to admit that
> in my early Git days I thought it looked damn odd.  Today I'm far
> too familiar with Git to really notice this as a problem now.

OK, I will confess I found it a little odd at first, but I think it's a
straightforward and playful extension of the language, which is
something I like. But you know, we have the corporate git customers to
think about these days. ;)

> I really don't have an opinion either way.  Actually I think the
> entire progress system of git-pack-objects should be reduced even
> further so that users aren't exposed to the internal phases we
> are going through.  Most of them just don't care.  They just
> want to know when its going to be done[*1*].

On a similar note, some complaints with progress meters, even after
recent patches:
  - When fetching, one progress meter says "Indexing" which, while
    technically true, is almost certainly blocking on "Downloading". In
    fact, it is not clear from the existing messages exactly _when_ we
    are downloading, and when we are just computing, which is something
    I think a user might want to know. Objections to changing this
    (though perhaps index-pack will need to be told when it is
    downloading and when it is just indexing)? Objections to a
    throughput indicator?
  - Running git-gc, we now get something like:
      Counting objects: 62317, done.
      Deltifying objects: 100% (18042/18042), done.
      Writing objects: 100% (62317/62317), done.
      Total 62317 (delta 43861), reused 61404 (delta 43036)
      Pack pack-32f8ac40c1a5ec146e45c657cb16f53fdd354095 created.
      Removing unused objects 100%...
      Done.
    Can we get rid of total statistics (I think this is useful for some
    power users, but perhaps there should be a verbosity level), the
    name of the pack file (same deal), and the totally useless "Done."?

-Peff
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux