On Tue, Mar 28, 2023 at 6:57 PM brian m. carlson <sandals@xxxxxxxxxxxxxxxxxxxx> wrote: > > On 2023-03-28 at 17:39:26, Felipe Contreras wrote: > > It's not difficult to make the testing library work for zsh, so I did that in > > the first patch. > > > > The rest of the patches are basically to deal with some variables that are > > special in zsh, workaround a bug, and a minor discrepancy. > > There was a point at which the tests worked entirely in sh mode with > zsh. I know because I fixed a handful of tests there, ending with > c64368e3a2a47, and I patched zsh to run all commands in a pipeline in a > subshell in sh mode to fix the remaining tests. > > If I symlink zsh (zsh 5.9 (x86_64-debian-linux-gnu)) to sh in a > temporary directory and use it in SHELL_PATH, I get only the following > failures: That would defeat my motivation behind the patches, which is to be able to run one test file in zsh. Only the first patch is needed for that, the rest were in case anyone cared to run all the tests. > I don't care a lot of other folks want to make zsh run the testsuite in > zsh mode, but I'd think that using sh mode would be simpler and less > likely to break in general, and would avoid us needing to carry a lot of > patches to work around various variables that are special in zsh mode. We don't need to carry the patches if the patches are applied. -- Felipe Contreras
