Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: > This series fixes numerous segfaults in config API users, because they > didn't expect *_get_multi() to hand them a string_list with a NULL in > it given config like "[a] key" (note, no "="'s). > > [..] > > * A trivial documentation change to 3/9, to clarify which doc in > config.h refer to what. As noted in the v7 discussion I think that > config.h could use some larger cleanups in this area, but let's > leave that for some future topic. > > [...] > > Range-diff against v7: > 1: 9f297a35e14 = 1: b600354c0f6 config tests: cover blind spots in git_die_config() tests > 2: 45d483066ef = 2: 49908f0bcf3 config tests: add "NULL" tests for *_get_value_multi() > 3: a977b7b188f ! 3: d163b3d04ff config API: add and use a "git_config_get()" family of functions > @@ config.h: void git_configset_clear(struct config_set *cs); > * value in the 'dest' pointer. > */ > > ++/** > ++ * git_configset_get() returns negative values on error, see > ++ * repo_config_get() below. > ++ */ > +RESULT_MUST_BE_USED > +int git_configset_get(struct config_set *cs, const char *key); > + Thanks! I read through config.h to be sure, and the result looks pretty clear to me. > 4: 3a5a323cd91 = 4: d7dfedb7225 versioncmp.c: refactor config reading next commit > 5: dced12a40d2 = 5: 840fb9d5c74 config API: have *_multi() return an "int" and take a "dest" > 6: d910f7e3a27 = 6: 75a68b14217 for-each-repo: error on bad --config > 7: 57db0fcd91f = 7: a78056e2748 config API users: test for *_get_value_multi() segfaults > 8: b374a716555 = 8: 686b512c3df config API: add "string" version of *_value_multi(), fix segfaults > 9: 6791e1f6f85 = 9: 6fce633493b for-each-repo: with bad config, don't conflate <path> and <cmd> Reviewed-by: Glen Choo <chooglen@xxxxxxxxxx>
