On Fri, Mar 24, 2023 at 08:58:39PM +0100, Oswald Buddenhagen wrote: > On Fri, Mar 24, 2023 at 03:13:02PM -0400, Jeff King wrote: > > On Fri, Mar 24, 2023 at 08:02:53PM +0100, Oswald Buddenhagen wrote: > > > maybe the operation just forgets to load the graph? > > > so i strace'd the thing, and there is indeed no appearance of 'commit-graph' > in the log. > > so i tried git log --graph ... and still nothing?! That "--graph" option is unrelated. It asks for Git to draw a graph in the output. Commit-graph is a fancy name for "a cache file which stores some metadata about commits so we can quickly answer graph-like queries such as ancestry, etc". > so weird in fact, that i tried another repository. and it works! > > so apparently something is wrong with my/the linux repository. > things i can imagine contributing to throwing it off somehow: > > $ git remote -v > alsa git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git (fetch) > alsa git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git (push) > history git://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git (fetch) > history git://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git (push) > linux-mips git://git.linux-mips.org/pub/scm/ralf/linux (fetch) > linux-mips git://git.linux-mips.org/pub/scm/ralf/linux (push) > linux-wireless git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers (fetch) > linux-wireless git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers (push) > origin git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git (fetch) > origin git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git (push) > ossi git@xxxxxxxxxx:ossilator/linux.git (fetch) > ossi git@xxxxxxxxxx:ossilator/linux.git (push) > > (the linux-* remotes haven't been pulled for years.) > > $ grep replace .git/packed-refs > a3628e41a9946c4fe93d9b2ae5906e1b2184fa8e refs/replace/1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Ah, that is your problem. When "replace" refs are in use, the data stored in the commit-graph can't reliably be used. It is storing invariants like "commit XYZ is the Nth generation from the root", which is an immutable property of a commit with a given hash. But as soon as you use grafts or replace refs, now we don't know if that information is valid or not (not just for the replaced commit, but for any of its ancestors which might have been replaced). So the whole thing is disabled. I'd guess you are grafting the "history" remote's contents onto the start of Linus's repo. It's probably better to do that in a one-off repository, rather than your day-to-day working one. But you can also flip it off and on at will. Try: git -c core.useReplaceRefs=false branch --contains ... which I think should get faster. And likewise you can set it to "false" in your config for day-to-day use, and then flip it on when you want to run a command that you think might query all the way down into ancient history. If it does make things faster for you, I'd still be curious to see the difference between "just commit graphs" and "commit graphs plus the patch I showed earlier". I think it should make things faster, but if it's only a few milliseconds on average, it's not that urgent to pursue. -Peff
