Re: git on afs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Thu, 18 Oct 2007, Todd T. Fries wrote:
> 
> 2) git presumes that DTYPE(de) != DT_DIR .. means the dirent is not a dir
>    this is not true for afs

That's a major bug, and has nothing to do with AFS. Oops. 

If you look just a bit lower, you'll see that just a few lines down, git 
handles DT_UNKNOWN correctly, and just does a lstat() on it as required. I 
guess that logic should be moved up, or alternatively the exclude logic 
should be moved down.

Your patch looks ok, but at the same time, I don't think it's really the 
right thing to do, since it now does that lstat() twice.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux