Re: [PATCH 3/8] sequencer: pass around rebase action explicitly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 3/8] sequencer: pass around rebase action explicitly
From: Oswald Buddenhagen <oswald.buddenhagen@xxxxxx>
Date: Thu, 23 Mar 2023 22:27:15 +0100
In-reply-to: <fa584725-52a5-ab7f-3f7b-2fc70fa8fbe1@dunelm.org.uk>
Mail-followup-to: git@xxxxxxxxxxxxxxx
References: <20230323162235.995574-1-oswald.buddenhagen@gmx.de> <20230323162235.995574-4-oswald.buddenhagen@gmx.de> <fa584725-52a5-ab7f-3f7b-2fc70fa8fbe1@dunelm.org.uk>

On Thu, Mar 23, 2023 at 07:27:25PM +0000, Phillip Wood wrote:

I appreciate the sentiment behind this patch, but it looks like anawful lot of churn just to clean up a couple of lines inappend_todo_help() and edit_todo_list().

as much as i dislike churn, i dislike fragile "magic" code even more.

References:
- [PATCH 0/8] sequencer refactoring
  - From: Oswald Buddenhagen
- [PATCH 3/8] sequencer: pass around rebase action explicitly
  - From: Oswald Buddenhagen
- Re: [PATCH 3/8] sequencer: pass around rebase action explicitly
  - From: Phillip Wood

Prev by Date: Re: [PATCH 2/3] sequencer: actually translate report in do_exec()
Next by Date: Re: [PATCH 7/8] sequencer: pass `onto` to complete_action() as object-id
Previous by thread: Re: [PATCH 3/8] sequencer: pass around rebase action explicitly
Next by thread: [PATCH 6/8] sequencer: simplify allocation of result array in todo_list_rearrange_squash()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]

Powered by Linux