Re: [PATCH 2/2] Fix mem leak in branch.c due to not-free newly added virtual_name variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 2/2] Fix mem leak in branch.c due to not-free newly added virtual_name variable
From: Junio C Hamano <gitster@xxxxxxxxx>
Date: Wed, 22 Mar 2023 13:52:45 -0700
Cc: ctmbl via GitGitGadget <gitgitgadget@xxxxxxxxx>, git@xxxxxxxxxxxxxxx
In-reply-to: <bd5207a0-9783-6a15-93da-0904ecd21341@gmail.com> (Clement Mabileau's message of "Wed, 22 Mar 2023 21:00:54 +0100")
References: <pull.1476.git.git.1679478126.gitgitgadget@gmail.com> <27f27f3afd76fc974350c0c94e20307879eead84.1679478126.git.gitgitgadget@gmail.com> <xmqqmt44enj3.fsf@gitster.g> <bd5207a0-9783-6a15-93da-0904ecd21341@gmail.com>
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)

Clement Mabileau <mabileau.clement@xxxxxxxxx> writes:

> I just did it!

Nice to hear.

> Thanks for the review.

Well, I didn't "review" anything, though.  I just commented on 2/2
that will become moot in your updated version, and I didn't even
look at 1/2.  

The change(s) as a whole need to be reviewed by somebody.

Thanks.

References:
- [PATCH 0/2] branch: improve error log on branch not found by checking remotes refs
  - From: ClementMabileau via GitGitGadget
- [PATCH 2/2] Fix mem leak in branch.c due to not-free newly added virtual_name variable
  - From: ctmbl via GitGitGadget
- Re: [PATCH 2/2] Fix mem leak in branch.c due to not-free newly added virtual_name variable
  - From: Junio C Hamano
- Re: [PATCH 2/2] Fix mem leak in branch.c due to not-free newly added virtual_name variable
  - From: Clement Mabileau

Prev by Date: Re: [EXTERNAL SENDER] Suspected git grep regression in git 2.40.0
Next by Date: Re: BUGREPORT: Modified files on a fresh clone on M2 MacBook Pro
Previous by thread: Re: [PATCH 2/2] Fix mem leak in branch.c due to not-free newly added virtual_name variable
Next by thread: [PATCH 1/2] branch: improve error log on branch not found by checking remotes refs
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]