On Fri, Mar 17, 2023 at 8:47 AM Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> wrote: > > Apply the part of "the_repository.pending.cocci" pertaining to > "cache.h". I know you said we only really needed to review 01-04, and 16-17, but I spot-checked this one anyway, particularly since it conflicted with what I was originally trying to include in https://github.com/gitgitgadget/git/pull/1493. But, I pulled that piece out to submit later, I'm in favor of the changes you are making here. Also, looking over this patch I think answered my question on the previous patch. You only needed the functions sorted by filename for the duration of your series, so that's good too. Anyway, looks good.