Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: > This change is an alternate direction to the topic at [1], this > expands on the vague suggestions I made in [2] to go in this > direction. Are you suggesting that we merge your patches instead of Glen's? (Or maybe merge your patches and a subset of Glen's, but I'm not sure which subset.) > As this shows we can split apart the "config_fn_t", and thus avoid > having to change the hundreds of existing "config_fn_t" callers. By > doing this we can already get rid of the current_config_kvi() > function, as "builtin/remote.c" and "t/helper/test-config.c" were the > only users of it. [snip] > This leaves the other current_config_*() functions. Subsequent commits > will need to deal with those. I think we already know that splitting config_fn_t is possible but the change will be quite widespread.
