On Thu, Mar 16, 2023 at 11:57 AM Glen Choo <chooglen@xxxxxxxxxx> wrote: > If users cleanly separate the two concepts, I think it is quite clear. > (I'm not advocating for this approach, but) e.g. if we pretend that each > behavior were configured separately, like: > > --[no-]rebase-merges [--rebase-merges-mode=(rebase-cousins|no-rebase-cousins)] > > I don't think there would be any confusion. Not being conversant with these options I agree the above isn't confusing. > (Having --rebase-merges-mode > be a no-op without --rebase-merges is probably even more confusing to > users, plus this would break backwards compatibility, so I don't think > this is a good idea at all.) I don't find it confusing. And how would it break backwards compatibility if --rebase-merges-mode doesn't exist now? -- Felipe Contreras
