Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: >> + /** >> + * These values store the computed counts for each side of the >> + * symmetric difference: >> + * >> + * 'ahead' stores the number of commits reachable from the tip >> + * and not reachable from the base. >> + * >> + * 'behind' stores the number of commits reachable from the base >> + * and not reachable from the tip. >> + */ >> + unsigned int ahead; >> + unsigned int behind; > > Even though this is the tip of the iceberg in terms of our codebase > overall, can't we just use "size_t" for counts in new APIs? I personally do not see a point in becoming so dogmatic. Plain (possibly) 32-bit integers have their places in the code.