On 23/03/14 01:21PM, Philippe Blain wrote: > Hi John, Hi Philippe, > > Le 2023-03-13 à 21:53, John Cai via GitGitGadget a écrit : > > This patch series adds support for bare repositories for the feature added > > in [1]. When using a bare repository, by default we will look for > > gitattributes from HEAD. When the --attr-source option is passed, we will > > try to read gitattributes from the commit. > > When I read that I immediately thought of the config settings 'mailmap.file', > 'mailmap.blob' which allow the same sort of thing, but for the mailmap. > > For the sake of consistency of the whole system, maybe we would want to support > 'attr.file' and 'attr.blob' ? In that case, maybe we don't need a new command > line option at all... I wasn't aware of those config options. Indeed that's a good option! My only concern with that is that there is already some precedence for passing a <tree-ish> as a source for attributes in [1], so I thought adding a command line option would be somewhat consistent. But I can also see the benefit of using a config value since there is also precedence because of mailmap.file and mailmap.blob. Not sure what others think, but this may be the less invasive way to go. 1. https://git-scm.com/docs/git-check-attr#Documentation/git-check-attr.txt---sourcelttree-ishgt > > Cheers, > > Philippe.
