Hi Junio On Tue, Mar 7, 2023 at 1:53 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > (Documentation/CodingGuidelines) > > - Redirection operators should be written with space before, but no > space after them. In other words, write 'echo test >"$file"' > instead of 'echo test> $file' or 'echo test > $file'. Note that > even though it is not required by POSIX to double-quote the > redirection target in a variable (as shown above), our code does so > because some versions of bash issue a warning without the quotes. Thanks for the styling reminders! I should go back and reread CodingGuidelines more often. > > + #add file to the index but outside of cone > > Can you have a SP after "#" here to make it more readable? Will do! > We create a new directory that is outside the cone, with or without > using the sparse-index feature. We know we are violating the cone, > and have to override the safety with the "--sparse" option. OK. > > What output do we expect out of "git add" to match in the two cases? > > > + #file present on-disk without modifications > > + test_sparse_match git diff-files && > > + test_sparse_match git diff-files newdirectory/testfile && > > As "diff-files" is about comparing between the index and the working > tree, the new path should not appear in the output when the sparse > checkout feature with or without the sparse-index feature is NOT in > use. Does the picture get different when we are sparse? IOW, would > we notice that we now have newdirectory/testfile that is supposed to > be missing in the index and show that in the output? I'm a bit caught up here. Do you mean I need to add a test for "git add" also? when we use "git add" instead of "git add --sparse ", we will get different. Cause newdirectory/testfile is missing in the index so diff-files will not work in these cases. > In a non-sparse repository whose HEAD commit does not have > 'testfile' (e.g. "git" source tree), I get > > $ git diff-files --find-object=HEAD:testfile > error: unable to resolve 'HEAD:testfile' > > without sparse checkout or sparse index. It is unclear what value > we get out of having this test here. Thanks for pointing out the error. HEAD:testfile is useless for the test here. ----------------------------------- Thanks Shuqi
