On Wed, Mar 08, 2023 at 11:35:06AM -0800, Junio C Hamano wrote: > "Derrick Stolee via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: > > > From: Derrick Stolee <derrickstolee@xxxxxxxxxx> > > > > When an object is not found in a repository's object store, we sometimes > > call reprepare_packed_git() to see if the object was temporarily moved > > into a new pack-file (and its old pack-file or loose object was > > deleted). This process does a scan of each pack directory within each > > odb, but does not reevaluate if the odb list needs updating. > > Very well explained, except I do not know what is meant by > "temporarily", which to me implies what was moved is moved back > later. Without "temporarily", it reads perfectly well. While I do > not think of a good word to use to tell the readers that the moving > is done by somebody else while we are trying to find the object, if > there were one, that would replace "temporarily" very well. > > But other than that tiny nit that does not have to be addressed at > all, everything in this patch looks good. s/temporarily/concurrently? I think that concurrently conveys that another process was doing the moving. But I agree that it doesn't matter here to aid in the overall understanding of what's happening in this patch. So I'd be fine with this patch as-is, with s/temporarily/concurrently, or with s/temporarily//. Thanks, Taylor
