Taylor Blau <me@xxxxxxxxxxxx> writes: > I don't think that splitting it into two separate patches was strictly > necessary. If I were queuing, I'd probably squash the two together, ... One advantage of sending a topic like this as two patches is that, if the review discussion leads to a consensus that the new help message should be given unconditionally to everybody, only [1/2] can be queued while dropping [2/2]. But the point of advise() is to serve as a training wheel that can be disabled by users who no longer need it, so need for such a "flexibility" may not appear in topics that add new advise() calls all that often, I would imagine. I am willing to do the squashing on the receiving end. The effect of two patches combined together is a good improvement, and the proposed log message for the first one covers why we want to do both of these two. Thanks, both, for writing and reviewing.
