Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: > Range-diff against v5: > 1: cefc4188984 = 1: 43fdb0cf50c config tests: cover blind spots in git_die_config() tests > 2: 91a44456327 = 2: 4b0799090c9 config tests: add "NULL" tests for *_get_value_multi() > 3: 4a73151abde = 3: 62fe2f04e71 config API: add and use a "git_config_get()" family of functions > 4: 382a77ca69e = 4: e36303f4d3d versioncmp.c: refactor config reading next commit > 5: 8f17bf8150c ! 5: e38523267e7 config API: have *_multi() return an "int" and take a "dest" > @@ config.c: void git_die_config(const char *key, const char *err, ...) > } > > ## config.h ## > -@@ config.h: int git_configset_add_parameters(struct config_set *cs); > +@@ config.h: int git_configset_add_file(struct config_set *cs, const char *filename); > /** > * Finds and returns the value list, sorted in order of increasing priority > * for the configuration variable `key` and config set `cs`. When the > 6: b515ff13f9b < -: ----------- config API: don't lose the git_*get*() return values > 7: 8a83c30ea78 = 6: 3a87b35e114 for-each-repo: error on bad --config > 8: d9abc78c2be = 7: 66b7060f66f config API users: test for *_get_value_multi() segfaults > 9: 65fa91e7ce7 = 8: 0da4cdb3f6a config API: add "string" version of *_value_multi(), fix segfaults > 10: 4db3c6d0ed9 = 9: 627eb15a319 for-each-repo: with bad config, don't conflate <path> and <cmd> I haven't reread the series in its totality yet (I should get to it in the next few days), but a small-ish thing that jumps out from the range-diff is that this version doesn't revert the commit message changes in the previous version (v5 CL [1]) that referred to the ejected 06/10. I.e. v5 said that we were changing the return values of the *_get_*() functions so that the new function is not a special snowflake, and those commit messages haven't been changed. 1. https://lore.kernel.org/git/cover-v5-00.10-00000000000-20230207T154000Z-avarab@xxxxxxxxx/
