On Tue, Feb 28, 2023 at 3:35 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > Calvin Wan <calvinwan@xxxxxxxxxx> writes: > > > Swapping `git add <submodule>` to `git submodule add <submodule>` > > in a previous patch created a .gitmodules file with multiple > > submodules pointing to the same path in certain tests. Fix tests > > so that they are run on the original added submodule rather than > > a separate manually configured submodule. > > Doesn't "git submodule add" have a way to give a specific name other > than the default taken from the path? If "git add sub" is converted > to "git submodule add --name subname ./sub", wouldn't these changes > become unnecessary? > If we converted to "git submodule add --name subname ./sub", we would instead have a different set of problems. For example, instances of git config --add -f .gitmodules submodule.subname.path sub git config -f .gitmodules submodule.subname.path sub and other similar lines would still need to be removed to prevent duplicate paths. That, however, seems like a better alternative than my current patch which replaces those removals with different ones.
