Hi Alex! It was great to see you at Review Club today. If you'd like the notes, they are available at https://docs.google.com/document/d/14L8BAumGTpsXpjDY8VzZ4rRtpAjuGrFSRqn3stCuS_w though reviewers will send their feedback to the mailing list anyway, so don't feel compelled to address feedback that isn't on the mailing list :) Alex Henrie <alexhenrie24@xxxxxxxxx> writes: > Changes from v4: > > [...] > > Suggestions not incorporated: > > [...] > I would have appreciated a sentence or two explaining the high level changes in this series, since that would save reviewers from having to read the whole series to get an idea of the overall intent. For this series, I think the subject line captures the intent pretty well, though even simple descriptions like "Add a config option. Also clean up some problems with the --rebase-merges flag." can be useful framing for reviewers. I appreciate the summary of changes [not] incorporated, I found it useful for getting an idea of what was originally discussed. On the whole, I think the config option will be quite welcome, and the series is mostly mergeable, but might benefit from some documentation tweaking.
