Junio C Hamano <gitster@xxxxxxxxx> writes: > * ab/config-multi-and-nonbool (2023-02-07) 10 commits > - for-each-repo: with bad config, don't conflate <path> and <cmd> > - config API: add "string" version of *_value_multi(), fix segfaults > - config API users: test for *_get_value_multi() segfaults > - for-each-repo: error on bad --config > - config API: don't lose the git_*get*() return values > - config API: have *_multi() return an "int" and take a "dest" > - versioncmp.c: refactor config reading next commit > - config API: add and use a "git_config_get()" family of functions > - config tests: add "NULL" tests for *_get_value_multi() > - config tests: cover blind spots in git_die_config() tests > > Assorted config API updates. > > Will merge to 'next'? > source: <cover-v5-00.10-00000000000-20230207T154000Z-avarab@xxxxxxxxx> I would prefer to eject 06/10 [1] for now and leave it in for a future cleanup series. I haven't confirmed whether it's safe (the practical effect of that patch is that the *_get() functions can now return -1 instead of 1, so the patch is safe if all callers only check if the return value is zero, and not whether it has a particular sign), and I don't think 06/10 is absolutely necessary to the series. But if we are already quite convinced that this is safe, I have no objections to merging it as-is. [1] https://lore.kernel.org/git/patch-v5-06.10-b515ff13f9b-20230207T154000Z-avarab@xxxxxxxxx
